CM-830: Add TrustManager API types for trust-manager operand#421
CM-830: Add TrustManager API types for trust-manager operand#421openshift-app-platform-shift[bot] wants to merge 1 commit intocert-manager-1.18from
Conversation
Introduces the TrustManager CRD (trustmanagers.operator.openshift.io/v1alpha1) as specified in the enhancement proposal (EP-1914). This cluster-scoped singleton resource enables day-2 installation and configuration of the trust-manager operand. Key additions: - TrustManager types with spec fields: logLevel, logFormat, trustNamespace, secretTargets, filterExpiredCertificates, defaultCAPackage, resources, affinity, tolerations, nodeSelector - SecretTargetsConfig with Custom/Disabled policy and authorizedSecrets - DefaultCAPackageConfig for OpenShift trusted CA bundle integration - FeatureTrustManager feature gate (Alpha, default disabled) - CRD manifest, deepcopy, client/lister/informer generation - Integration tests for CRD validation (status defaults, singleton, scope, immutability) - YAML test suite covering create/update validation scenarios Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-app-platform-shift[bot]: This pull request references CM-830 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @openshift-app-platform-shift[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-app-platform-shift[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/close |
|
@swghosh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Summary
TrustManagerCRD (trustmanagers.operator.openshift.io/v1alpha1) as specified in enhancement proposal EP-1914FeatureTrustManagerfeature gate (Alpha, default disabled) for TechPreview gatingChanges
New Files
api/operator/v1alpha1/trustmanager_types.go— TrustManager, TrustManagerSpec, TrustManagerConfig, SecretTargetsConfig, DefaultCAPackageConfig, TrustManagerControllerConfig, TrustManagerStatus, and enum typesapi/operator/v1alpha1/trustmanager_types_test.go— CRD integration tests (status defaults, singleton, scope, immutability)api/operator/v1alpha1/tests/trustmanagers.operator.openshift.io/trustmanager.testsuite.yaml— YAML test suite with 28 onCreate and 7 onUpdate validation scenariosconfig/crd/bases/operator.openshift.io_trustmanagers.yaml— Generated CRD manifestModified Files
api/operator/v1alpha1/features.go— AddedFeatureTrustManagerfeature gateapi/operator/v1alpha1/zz_generated.deepcopy.go— Auto-generated deepcopy methodsKey API Fields
trustManagerConfig.logLevel(1-5),logFormat(text/json)trustManagerConfig.trustNamespace(immutable, default: cert-manager)trustManagerConfig.secretTargets(Disabled/Custom with authorizedSecrets)trustManagerConfig.filterExpiredCertificates(Enabled/Disabled)trustManagerConfig.defaultCAPackage(Enabled/Disabled)trustManagerConfig.resources,affinity,tolerations,nodeSelectorcontrollerConfig.labels,controllerConfig.annotationsTest plan
go build ./api/...compiles successfullymake generate && make manifestsruns without errorsgo test ./api/operator/v1alpha1/... -run TestTrustManager)🤖 Generated with Claude Code